Github Pull Request
| From: | David Soria Parra | Date: | Tue, 20 Mar 2012 10:16:50 +0000 |
| Subject: | Github Pull Request | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-59074@lists.php.net to get a copy of this message | ||
Hi
with the php-src migrated to git we start receiving
pull request on github. A few things to notice:
- developers can pull the requests as described here:
https://wiki.php.net/vcs/gitfaq#github_pull_requests
- people with valid github accounts can comment
on pull request
- people with valid php accounts can close pull
request using the tool http://qa.php.net/pulls.
Thank you joahnnes for writing it.
Before pulling make sure:
- the pull request contains appropriate tests for
the change
- the commit message contains a good and precise
description what was changed and why
ensure that you pull it into the right branch.
Pull request notifications are send to the
git-pulls@lists.php.net mailinglist.
Note that we DONT hand out access to the
github repository and will we not add
you to the PHP organization on github.
- David