Re: Re: cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/exif exif.c
| From: | (Marcus Börger) | Date: | Wed, 02 Apr 2003 08:37:57 +0000 |
| Subject: | Re: Re: cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/exif exif.c | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-595@lists.php.net to get a copy of this message | ||
At 07:30 02.04.2003, Andi Gutmans wrote:
I'm not completely sure but from first glance at exif it is *completely* broken everywhere. You're not supposed to use zval_dtor() on parameters you get via zend_get_parameters_ex(). They are read-only as they are reference counted and are possibly pointed to by other variables too. You should use zend_get_parameters() if you want to be able to change them (such as calling zval_dtor()).All three in question are marked FORCE_BYREF_REST, so we only need to drop the zval_dtor() calls. marcus