Re: Re: cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/exif exif.c
| From: | Rasmus Lerdorf | Date: | Thu, 01 Jan 1970 00:00:00 +0000 |
| Subject: | Re: Re: cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/exif exif.c | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-628@lists.php.net to get a copy of this message | ||
On Wed, 2 Apr 2003, Andi Gutmans wrote:
> I'm not completely sure but from first glance at exif it is *completely*
> broken everywhere.
> You're not supposed to use zval_dtor() on parameters you get via
> zend_get_parameters_ex(). They are read-only as they are reference counted
> and are possibly pointed to by other variables too. You should use
> zend_get_parameters() if you want to be able to change them (such as
> calling zval_dtor()).
Looking around a bit, parse_str(), getimagesize() and preg_match() all do:
zend_get_parameters_ex(1, arg)
zval_dtor(arg);
array_init(arg);
These are broken too then?
-Rasmus