Re: BC broken for strrpos()/strripos()
| From: | Sara Golemon | Date: | Wed, 03 Dec 2003 00:56:32 +0000 |
| Subject: | Re: BC broken for strrpos()/strripos() | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-6038@lists.php.net to get a copy of this message | ||
> this night i saw that the BC of strrpos()/strripos()
> is broken by a patch commited by pollita 7 months ago :
>
http://cvs.php.net/diff.php/php-src/ext/standard/string.c?login=2&r1=1.370&r2=1.371&ty=u
> The documenation of both function states if the second parameter is an
> integer instead of string then its value is used as a ord of the character
> to be used during the search. This no more true with HEAD.
>
Good catch. This should not have been broken, I'll fix this.
> What do you think? Is it ok to break the BC here or not? As you see the
> other change introduced with the patch is to use the whole needle string
> while searching, not only the first character.
>
That break was intentional. Having strrpos() behave differently from
strpos() in regards to needle size was not a good thing.
-Sara