Re: Re: BC broken for strrpos()/strripos()

From:	Andrey Hristov	Date:	Wed, 03 Dec 2003 01:01:52 +0000
Subject:	Re: Re: BC broken for strrpos()/strripos()
References:	1 2	Groups:	php.internals
Request:	Send a blank email to internals+get-6040@lists.php.net to get a copy of this message

Sara Golemon wrote:

The documenation of both function states if the second parameter is an integer instead of string then its value is used as a ord of the character to be used during the search. This no more true with HEAD.
Good catch. This should not have been broken, I'll fix this. okie

What do you think? Is it ok to break the BC here or not? As you see the other change introduced with the patch is to use the whole needle string while searching, not only the first character.
That break was intentional. Having strrpos() behave differently from strpos() in regards to needle size was not a good thing. In this case it should be stated somewhere maybe in the still imaginery

"the_thin_differences_between_PHP4_and_PHP5.txt"

-Sara

Andrey