Re: PBKDF2 addition to OpenSSL - Why Not Hash?
| From: | Derick Rethans | Date: | Tue, 12 Jun 2012 12:18:16 +0000 |
| Subject: | Re: PBKDF2 addition to OpenSSL - Why Not Hash? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-60801@lists.php.net to get a copy of this message | ||
On Tue, 12 Jun 2012, Anthony Ferrara wrote:
> Hello all,
>
> I noticed that yesterday a patch was committed to trunk to add PBKDF2
> support to the OpenSSL extension. I also noted that in the commit
> message, the author indicated that he would have rather added it to
> the hash extension, but wasn't able to.
Why wasn't he been able to?
> I had added a patch back in January for that very feature (adding
> PBKDF2 to Hash). https://bugs.php.net/bug.php?id=60813
>
> Personally, I'd MUCH rather see it in hash(), as it's enabled on far
> more installs (every one) than openssl, Because of this, I think it
> would be far more useful to add it to hash.
>
> Should I create a pull request for this, to implement it in hash
> instead of OpenSSL? What do you think?
Doesn't hurt to have it in both of course... So sure.
Derick