Re: PBKDF2 addition to OpenSSL - Why Not Hash?
| From: | Anthony Ferrara | Date: | Tue, 12 Jun 2012 12:45:14 +0000 |
| Subject: | Re: PBKDF2 addition to OpenSSL - Why Not Hash? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-60802@lists.php.net to get a copy of this message | ||
Derick,
>> I noticed that yesterday a patch was committed to trunk to add PBKDF2
>> support to the OpenSSL extension. I also noted that in the commit
>> message, the author indicated that he would have rather added it to
>> the hash extension, but wasn't able to.
>
> Why wasn't he been able to?
I haven't spoken to him, but here's part of his original commit
message ( https://github.com/php/php-src/commit/f4847efc5d58b3375fa0f3269158d5e6ab625c21
)
No easy way to put these in the hash extension since we don't really
support optional
parameters to certain algorithms. Implemented in openssl for now since
it has it already
and is pretty stable.
> Doesn't hurt to have it in both of course... So sure.
Ok, I'll add it to my list to forward port it to git and submit the PR...
Anthony