Asking for a review of crypt() allocation changes

Hi internals! Anthony and me have been looking a lot at the crypt() code recently and noticed that there are some strange things going on in the buffer allocations for the sha algorithms. We did two commits to fix them up a bit: http://git.php.net/?p=php-src.git;a=commitdiff;h=7e8276ca68fc622124d51d18e4f7b5cde3536de4 http://git.php.net/?p=php-src.git;a=commitdiff;h=e6cf7d774519300c08399cae5bfba90e33749727 The complete code is here: http://lxr.php.net/xref/PHP_TRUNK/ext/standard/crypt.c#150 To prevent another crypt() mess, I'd really appreciate if some people familiar with the code could look over it. Nikita