Re: Session Id Collisions

Hi, Sorry for the long delay, I've sent pull requests https://github.com/php/php-src/pull/368 https://github.com/php/php-src/pull/367 https://github.com/php/php-src/pull/366 Thank you for your time. -- Yasuo Ohgaki yohgaki@ohgaki.net 2012/12/24 Yasuo Ohgaki <yohgaki@ohgaki.net> > Hi stats and others, > > Sorry for the delay. > I've finally updated the strict session patch. > > Following diff is against PHP-5.3, but 5.4 and others will be mostly the > same. > > > > https://github.com/yohgaki/php-src/commit/42dcd8ef7cd2f9f2071b16586822dadd647c96ef > > I was promised to create separate patch for session id collision > detection, but > the patch is also in the diff. I left comments for the "if" statement > handles > collision. If you still prefer to have separate patch, I'll do it when > I send pull requests. > > If nobody has comment, I'll create patch for 5.4. > > If you read this patch closely, you'll see that this patch accesses > PS(id) global directly due to limitation of current API. It would be > good to have new API for 5.5, I think. > > BTW, this patch fixes bug #60634 as a side effect also. > https://bugs.php.net/bug.php?id=60634 > > Comments are appreciated. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net >