Re: Session Id Collisions
| From: | Yasuo Ohgaki | Date: | Mon, 05 Aug 2013 01:01:31 +0000 |
| Subject: | Re: Session Id Collisions | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68370@lists.php.net to get a copy of this message | ||
Hi Stas,
On Mon, Aug 5, 2013 at 9:45 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
> >> https://github.com/php/php-src/pull/368
> >> https://github.com/php/php-src/pull/367
> >> https://github.com/php/php-src/pull/366
>
> I've amended your patch slightly:
> https://github.com/php/php-src/pull/401
>
> and it looks fine to me now. What do you think, is it OK with you?
Thank you for noticing crash. Data can be null, so the fix is OK.
Removing the limitation that prohibits setting session ID is fine for me,
too.
Please, apply your patch.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net