Re: Pull requests report (17/7/2013)
| From: | Lior Kaplan | Date: | Thu, 18 Jul 2013 19:57:57 +0000 |
| Subject: | Re: Pull requests report (17/7/2013) | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68168@lists.php.net to get a copy of this message | ||
On Thu, Jul 18, 2013 at 10:00 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
> > Also, we have more than a few PR which the patch is OK, but are stuck due
> > to a
> > missing test. This is fair enough, but should also have some rule of
> thumb
> > for
> > these cases.
>
> Again, it would not be hard to add tests for many of them, the problem
> is again - time. For myself, I'd rather spend time on merging properly
> done patches or fixing bugs than finishing up patches that the original
> author could finish up. But if some people decide that this is a good
> way for them to contribute - that'd be great. Otherwise, removing these
> pulls from public view would only mean they'd never get taken care at all.
Maybe offer the list of needed tests as an easy task/hack so even people
not into
the internals could contribute. e.g.
https://wiki.documentfoundation.org/Easy_Hacks
Might be a win win for everybody ? (although some help might still be
needed)
Kaplan