Re: Pull requests report (17/7/2013)
| From: | Yasuo Ohgaki | Date: | Thu, 18 Jul 2013 20:44:03 +0000 |
| Subject: | Re: Pull requests report (17/7/2013) | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68169@lists.php.net to get a copy of this message | ||
Hi Stas
2013/7/19 Stas Malyshev <smalyshev@sugarcrm.com>
> > Indeed we started with the easy ones... there isn't any reason simple
> > patches
> > won't get merged very quickly.
>
> There's a very simple reason - there are not enough people with enough
> knowledge about PHP internals to properly evaluate patches that do it on
> regular basis. Even the simplest patch takes time, at least if you do it
> the right way - you have to read it, understand if it's right, pull it,
> build with it, run tests with it if it has tests, merge it to multiple
> branches, etc. - this takes time. Time is a scarce resource.
I completely agree.
Why don't we state this fact in bugs.php.net and github that bug/PR will
take time to be addresses?
It's better to give contributors expectation how long it may take time to
be addresses?
It's not a solution, but it's better than nothing.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net