RE: [PHP-DEV] If you want to avoid annoying CS commits
| From: | Joseph Tate | Date: | Fri, 04 Apr 2003 17:11:16 +0000 |
| Subject: | RE: [PHP-DEV] If you want to avoid annoying CS commits | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-683@lists.php.net to get a copy of this message | ||
How about documenting an astyle (insert stylizing app of choice here) line
in CODING_STANDARDS that people can run on their code to make it conform to
said standards. Then people can just run $astyle on their file before they
commit it.
Joseph
> -----Original Message-----
> From: Sterling Hughes [mailto:sterling@bumblebury.com]
> Sent: Friday, April 04, 2003 11:45 AM
> To: Sascha Schumann
> Cc: internals@lists.php.net
> Subject: Re: [PHP-DEV] If you want to avoid annoying CS commits
>
>
> On Fri, 2003-04-04 at 11:54, Sascha Schumann wrote:
> > Sterling, you are missing some important points here.
> >
> > > Geeze Luise, its not that hard, and the coding standards are
> there for a
> > > (good) reason. If you object to some of the standards, discuss that,
> >
> > If you look at my code, 99% of it follows the coding styles,
> > because I've adopted the PHP style as my personal one.
> >
> > The commit I recently backed out related mostly to Zeev's
> > "terse" style. While I'm not particular fond of it, there is
> > also no reason why it absolutely has to be realigned.
> >
> > I barked at Derick for trying to police me with his docref
> > pet stuff. I just noticed that someone has committed that to
> > CODING_STANDARDS, although there has never been a consensus
> > regarding its introduction. As such, I consider it to be
> > void.
> >
>
> Ahh, well, you should follow the coding standards regardless, or rather
> change them. I've just removed docref and assert bogusness from the
> files, so, in that case, you are no longer in violation. (you should
> throw a party. ;-)
>
> What I was objecting to was less contraversial, long term coding
> standards, for example:
>
> if (foo) bar = 1;
>
> instead of :
>
> if (foo) {
> bar = 1;
> }
>
> Its really quite simple to follow, and if you want to avoid annoying CS
> commits, just follow the standards.
>
> -Sterling
> --
> "The three most dangerous things in the world are a programmer
> with a soldering iron, a hardware type with a program patch and
> a user with an idea."
> - Unknown
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>