RE: [PHP-DEV] If you want to avoid annoying CS commits

On Fri, 2003-04-04 at 19:35, Sterling Hughes wrote: > On Fri, 2003-04-04 at 12:42, Martin Jansen wrote: > > On Fri, 2003-04-04 at 19:15, Sterling Hughes wrote: > > > On Fri, 2003-04-04 at 12:26, Martin Jansen wrote: > > > > "In PECL all code has to follow the PHP coding standards." > > > > (http://pear.php.net/manual/en/developers.meaning.php) > > > > > > > > > > Then the manual is wrong. > > > > Oh, come on: You should have come up with that at the time that Stig > > hammered out PECL. > > Speak Now or forever hold your peace? That's now what I meant to say and you know that. What I intended to say was that it's not very productive to question something _after_ it has been hammered out, if you had the chance to actively influence it's direction _before_ there was a decision. > Got news for you, 3/4s of the stuff in pecl doesn't follow the coding > standards. I just looked at the first 5 modules by ls, none of them > were coding standards compliant. In this case the people, who wrote that code, haven't read the passage from the manual, which I've quoted. Sad but true. > What's the point, really? PECL modules are not group maintained (like > PEAR modules). If I woke up one day and saw someone committed to my > pecl module without my consent (or without contacting me first), I would > revert it just for good measure.. When you have something in PECL, its > *your* project, its not everyone's business (like in PHP). Hmm, I can see the danger of PECL becoming a "garbage dump" in this sentences. But may be I'm wrong. > Also developing PHP extensions is much different than developing PHP. > In PHP extensions the code itself is much more encapsulated, in PECL > individual package development is encapsulated. As long as the code > follows the php naming conventions (for exported functions), it can > interact nicely with the other packages. Again: This point of view seems to clash with the vision that Stig and some others over at pear-dev had about PECL. Anyways, I don't really care about PECL much at the moment and thus won't invest to much energy in this discussion ;-). - Martin