Re: Support for keywords where possible

Am 12.9.2013 um 15:06 schrieb Michael Wallner <mike@php.net>: > On 12 September 2013 14:56, Bob Weinand <bobwei9@hotmail.com> wrote: >> A little benchmark here: >> https://gist.github.com/bwoebi/6536824 >> >> Here I picked always the best from 10 times running. >> >> With patch: >> root# ./sapi/cli/php microbench.php >> Took for 10000 iterations: 8.6687519550323 seconds >> >> Without patch: >> root# ./sapi/cli/php ../bwo-php-src/microbench.php >> Took for 10000 iterations: 8.5741410255432 seconds >> >> But this is the very worst case. (e.g. there are JUST cases where strncasecmp needs to be >> used) > > Is there a number missing after "JUST"? no… I mean, in the benchmark are included all the cases where strncasecmp needs to be used. >> When picking random files the results are pretty similar: > > What random files? Some PHP files that were on my server >> >> With patch: >> root# ./sapi/cli/php microbench.php >> Took for 10000 iterations: 15.564201116562 seconds >> >> Without patch: >> root# ./sapi/cli/php microbench.php >> Took for 10000 iterations: 15.562065023422 seconds >> >> It's here only a difference of about 2 milliseconds or 0,01% what is in the margin of >> error I think. > > I'd love to have the freedom your patch provides, but I'm not convinced yet :) > How does it affect running one of the major frameworks out there? > > > -- > Regards, > Mike As Benjamin suggested, here the best running times of "time phpunit" in the symfony test suite: With patch: real 0m30.885s user 0m14.713s sys 0m2.123s Without patch: real 0m31.380s user 0m14.865s sys 0m2.170s Seems that it is very similar (I have here variances of ±2 seconds…) So I think my patch doesn't have a huge impact. Bob Weinand