Re: Support for keywords where possible
| From: | Pierre Joye | Date: | Thu, 12 Sep 2013 16:18:41 +0000 |
| Subject: | Re: Support for keywords where possible | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-69102@lists.php.net to get a copy of this message | ||
hi,
On Thu, Sep 12, 2013 at 4:34 PM, Bob Weinand <bobwei9@hotmail.com> wrote:
> As Benjamin suggested, here the best running times of "time phpunit" in the symfony
> test suite:
>
> With patch:
> real 0m30.885s
> user 0m14.713s
> sys 0m2.123s
>
> Without patch:
> real 0m31.380s
> user 0m14.865s
> sys 0m2.170s
>
> Seems that it is very similar (I have here variances of ±2 seconds…) So I think my patch
> doesn't have a huge impact.
We will try to run it through our performance tests suite here,
against more applications. I do not think we will see different
results but at least the coverage will be large enough to make an
informed choice :)
About the idea itself, I like it and all for it, as long as it does
not introduce any BC breaks. I doubt there is any and testing it
intensively against existing apps will clear this point.
Cheers,
--
Pierre
@pierrejoye | http://www.libgd.org