Re: Improved performance of array_maerge() and func_get_args()
| From: | Dmitry Stogov | Date: | Wed, 23 Oct 2013 19:20:43 +0000 |
| Subject: | Re: Improved performance of array_maerge() and func_get_args() | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-69816@lists.php.net to get a copy of this message | ||
On Wed, Oct 23, 2013 at 6:21 PM, Levi Morrison <morrison.levi@gmail.com>wrote:
>
> I'm proposing two simple patches that eliminate a lot of useless zval
>> copying.
>> For example they remove only about 800 calls to zend_hash_copy() (25%) on
>> each request to wordpress-3.6.0 home page and make it 2-4% faster.
>>
>
> Sounds great. Thank you for looking into this. Just to clarify: the
> wordpress improvements were from both patches, yes?
>
Yes, both patches together.
>
>>
>> It's not a questions about master branch, but I think it is also safe to
>> commit them into PHP-5.4 and PHP-5.5.
>>
>> Any objections?
>>
>
> I don't have an objection; I just want to reiterate that changing code can
> introduce BC breaks and to be careful when backporting it. Just be careful.
>
Of course we checked them careful for possible BC breaks, but we may miss
some special cases.
Thanks. Dmitry.