Re: Improved performance of array_maerge() and func_get_args()
| From: | Christopher Jones | Date: | Thu, 24 Oct 2013 00:17:06 +0000 |
| Subject: | Re: Improved performance of array_maerge() and func_get_args() | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-69822@lists.php.net to get a copy of this message | ||
On 10/23/2013 05:36 AM, Dmitry Stogov wrote:
Hi, I'm proposing two simple patches that eliminate a lot of useless zval copying. For example they remove only about 800 calls to zend_hash_copy() (25%) on each request to wordpress-3.6.0 home page and make it 2-4% faster. It's not a questions about master branch, but I think it is also safe to commit them into PHP-5.4 and PHP-5.5. Any objections? https://gist.github.com/dstogov/7117623 https://gist.github.com/dstogov/7117649 Thanks. Dmitry.I'd prefer PHP 5.4 was kept stable. Last time I suggested keeping PHP 5.4 stable [1], it wasn't, and the result was a performance regression [2]. Chris References: [1] http://marc.info/?l=php-internals&m=135820887521861 [2] http://marc.info/?l=php-internals&m=137037681223946 -- christopher.jones@oracle.com http://twitter.com/ghrd Free PHP & Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html