Re: Re: Fix for bug #50333

Hi Dmitry, On Wed, 2013-10-30 at 16:00 +0400, Dmitry Stogov wrote: > Hi Anatol, > > I've posted few comments at > https://github.com/php/php-src/pull/500/files > Otherwise, the patch looks fine. > I think it may be accepted even if it doesn't make visible improvement. > Of course, when the small issues described in comment are fixed. > > There were also a minor merging conflict in ext/opcache/ZendAccelerator.c > (it's not a problem at all). > > I hope you testd ZTS PHP with patch well, because I mainly care about > non-ZTS builds. > > Thanks. Dmitry. thanks for the time you spend on this. The remaining fixes are on their way, they'll be tested well functionally+performance. I'll write back as soon as all that is done. What just comes in my mind, the original idea was invented on Solaris, so maybe there's something specific to that platform what makes it faster there. In the ticked is also mentioned "scalability on multi-threaded/multi-core systems", so maybe some more special conditions are needed. Maybe like some particular CPU cores count (currently we do it with 2 or 4 cores) or specific server load level. I'm going to play more with that. Best regards Anatol