Re: Re: Fix for bug #50333

Hi Anatol, I don't see any technical problems with the patch. Thanks. Dmitry. On Sat, Nov 2, 2013 at 4:45 PM, Anatol Belski <ab@php.net> wrote: > Hi Dmitry, > > On Wed, October 30, 2013 13:00, Dmitry Stogov wrote: > > Hi Anatol, > > > > > > I've posted few comments at > https://github.com/php/php-src/pull/500/files > > Otherwise, the patch looks fine. > > I think it may be accepted even if it doesn't make visible improvement. > > Of course, when the small issues described in comment are fixed. > > > > > > There were also a minor merging conflict in ext/opcache/ZendAccelerator.c > > (it's not a problem at all). > > > > > > I hope you testd ZTS PHP with patch well, because I mainly care about > > non-ZTS builds. > > > > Thanks. Dmitry. > > > > I've fixed the patch according to your last comments. Just a note about > virtual_cwd_activate() being called twice. That is needed for the threaded > environment, once for SAPI startup and then per request in > zend_activate(), as that calls belong to different threads. > > The performance has at least no regressions, here's the report > > > > http://windows.php.net/downloads/snaps/ostc/pftt/perf/results-20131101-MasterVanilla-Master50333Patch2-2742.html > > The functional tests have also no regressions from recent master. > > Regards > > Anatol > >