Re: Review requested: use-function patch

From:	Joe Watkins	Date:	Thu, 14 Nov 2013 13:45:20 +0000
Subject:	Re: Review requested: use-function patch
References:	1 2	Groups:	php.internals
Request:	Send a blank email to internals+get-70112@lists.php.net to get a copy of this message

On 11/14/2013 01:11 PM, Igor Wiedler wrote:

Hi, Just bumping this thread, since it didn’t receive any attention at all. Thanks, Igor On 09 Nov 2013, at 20:08, Igor Wiedler <igor@wiedler.ch> wrote:
Hello internals, It’s been a while since the use-function RFC was accepted (reminder: https://wiki.php.net/rfc/use_function). The last few edge case bugs that had come up have now been fixed. As far as I’m concerned, the patch is complete. It would be great to get some more review to ensure there are no issues in the implementation. And once that’s done, it can be merged. The patch is at: https://github.com/php/php-src/pull/526 Thanks, Igor
Look fine, I did read it the other day and forgot to reply ... sorry bout that ...

There are very few conventions within the source, one of them is the use of the variable name lcname, might be nice to be consistent and use the same name. I see a couple of dereferences that weren't there before, any particular reason for that ? Cheers Joe