Re: Review requested: use-function patch

From: Date: Thu, 14 Nov 2013 15:15:26 +0000
Subject: Re: Review requested: use-function patch
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to internals+get-70116@lists.php.net to get a copy of this message
On 14 Nov 2013, at 15:45, Michael Wallner <mike@php.net> wrote: > On 14 November 2013 15:42, Michael Wallner <mike@php.net> wrote: >> On 14 November 2013 14:11, Igor Wiedler <igor@wiedler.ch> wrote: >>> Hi, >>> >>> Just bumping this thread, since it didn’t receive any attention at all. >> >> Sorry! >> Igor, did you fully merge my fixes branch yet? > > There's a fix for which I obviously did not create a PR: > > https://github.com/m6w6/php-src/compare/igorw:use-function...use-function I missed that patch. But it looks like Adam did an alternate fix: * https://github.com/igorw/php-src/commit/9711c58bc4236c0e2e482af9b20581e78af0c7ca If that is not sufficient, can you please send an updated pull request against the current branch? Thanks! Igor

« previous php.internals (#70116) next »