Re: Comments on non-unique naming convention for closures

Hi! > +1 on avoiding time-related system calls -- even though these are pretty > optimized on current Linux kernels -- however this is why we suggested a > content based hash. Any alternatives that I can think of require a > materially larger larger patch involving more source changes. I understand why you proposed content-based hash. What I was suggesting is not replacing it but amending it to produce different hash even in case same code would be encountered in different places - e.g. by hashing not only the text but also filename & line number (or counter). I'm not sure if it is strictly necessary for OPcache (could be that it is not) but in general having multiple functions with the same name floating around is not a very good idea, IMO, if we can avoid it... After all, that's how we got this problem from the start :) -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227