Re: strtr() performance degradation

On Tue, Dec 3, 2013 at 9:29 AM, Zeev Suraski <zeev@zend.com> wrote: > To put things in perspective, the work that goes into improving PHP's > performance by 10% is measured in months, sometimes more (from inception to > production). Here, we have a patch that slowed real world apps (not > synthetic benchmarks) by over 10%, and despite the fact it was reported 6 > months ago, we've done absolutely nothing about it. If anything in that > story doesn't make sense, that would be it. I cannot agree more than performance is part of the CI/QA process and should be taken as blocker on release time (if any regressions are noticed). We do that on a daily basis for every commit and alerts are sent if there is a performance impact superior to 1-3%. However I have hard time to imagine than strstr alone can reduce real apps performance by 10%, unless we are talking about one single module using it intensively. Do you have numbers and the way you tested it pls? > We should revert this patch ASAP; It's unfortunate we haven't done it back > when it was found but better late than never. I'm not too fund to revert in stable series. But I'm fine to revert it for 5.6.0 if the performance impact has not been solved by the time we will release the final release. Once it is out (optimized back or reverted), we can always consider it for 5.5 or eventually 5.4. Cheers, -- Pierre @pierrejoye | http://www.libgd.org