Re: strtr() performance degradation

On Tue, Dec 3, 2013 at 9:30 PM, Pierre Joye <pierre.php@gmail.com> wrote: > hi Dmitry! > > > On Tue, Dec 3, 2013 at 12:24 PM, Dmitry Stogov <dmitry@zend.com> wrote: >> >> ZF2 :) >> Screen-short explains it. >> >> Thanks. Dmitry. >> >> >> > > > Thanks for the shot :) > > However what is used to produced this call stack? I can imagine that a > zf2 specific method could suffer from this regression, but I still > have hard time to see a full app suffering from it (12%). > > The only reason I insist is that we already had "simply revert" in the > past, which ended being incomplete or with mistakes, leading to much > more critical problems. That's what I would like to prevent in stable > releases. Hey: There are two options 1. fixed the regression based on current implementation, which will be a little ugly.. 2. revert it and try to make a optimization based on the previous implementation... which obviously won't have BC break. and more safe than 1.. I propose revert it in the next release, (5.4, 5.5, 5.6, and master).. please, lets' make it simple... the previous implementation worked well... thanks > > > Cheers, > -- > Pierre > > @pierrejoye | http://www.libgd.org -- Laruence Xinchen Hui http://www.laruence.com/