Re: TSRMLS_FETCH crusade (was: Re: [PHP-CVS] com php-src: Eliminate another TSRMLS_FETCH())
| From: | Nikita Popov | Date: | Wed, 18 Dec 2013 15:03:41 +0000 |
| Subject: | Re: TSRMLS_FETCH crusade (was: Re: [PHP-CVS] com php-src: Eliminate another TSRMLS_FETCH()) | ||
| References: | 1 2 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-70732@lists.php.net to get a copy of this message | ||
On Wed, Dec 18, 2013 at 12:03 PM, Mike <mike.php.net@gmail.com> wrote:
> On Wed, 2013-12-18 at 06:25 +0000, Kalle Sommer Nielsen wrote:
> > Commit: d14670ccdb2782abaaaa721d1c379138fa64aae6
> > Author: Kalle Sommer Nielsen <kalle@php.net> Wed, 18 Dec
> 2013 07:25:05 +0100
> > Parents: 1433dec2d0c00fcda5bebaeebefca8264deb912a
> > Branches: master
> >
> > Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=d14670ccdb2782abaaaa721d1c379138fa64aae6
> >
> > Log:
> > Eliminate another TSRMLS_FETCH() in i_zend_is_true()
> >
> > # Affected extensions have all been updated, ext/opcache and ext/zip
> > # both have macros for cross version compatibility
>
> What's with all the other extensions? PECL or wild? That TSRMLS_FETCH
> crusade seems pretty worthless as long as it is found in _emalloc etc.
>
I'm also concerned about those commits. They all seem to be dealing with
TSRMLS_FETCH calls in non-perf critical places (like the *object cast* part
of zend_is_true...), but a lot of them break source compatibility for
extensions. This just doesn't seem worth it.
Nikita