Re: TSRMLS_FETCH crusade

On Wed, 2013-12-18 at 13:30 +0000, Joe Watkins wrote: > On 12/18/2013 01:06 PM, Derick Rethans wrote: > > On Wed, 18 Dec 2013, Mike wrote: > > > >> On Wed, 2013-12-18 at 06:25 +0000, Kalle Sommer Nielsen wrote: > >>> Commit: d14670ccdb2782abaaaa721d1c379138fa64aae6 > >>> Author: Kalle Sommer Nielsen <kalle@php.net> Wed, 18 Dec 2013 > >>> 07:25:05 +0100 > >>> Parents: 1433dec2d0c00fcda5bebaeebefca8264deb912a > >>> Branches: master > >>> > >>> Link: > >>> http://git.php.net/?p=php-src.git;a=commitdiff;h=d14670ccdb2782abaaaa721d1c379138fa64aae6 > >>> > >>> Log: > >>> Eliminate another TSRMLS_FETCH() in i_zend_is_true() > >>> > >>> # Affected extensions have all been updated, ext/opcache and ext/zip > >>> # both have macros for cross version compatibility > >> > >> What's with all the other extensions? PECL or wild? That TSRMLS_FETCH > >> crusade seems pretty worthless as long as it is found in _emalloc etc. > > > > A much nicer thing would be to just get rid of TS and TSRMLS in the > > first place across the board. > > > > cheers, > > Derick > > > > If you mean having to pass it around or fetch it, I agree ... > > There is a patch for native tls, it has a mode where TSRMLS_anything is > removed completely, no has no function but doesn't break anything (empty > define), a couple of months ago we had it working with master ... > > Big job, intend to do it one day ... > So... anything to add here? I saw Sara doing the first PECL extension adjustments for PHP-5.7 and I already dislike the ifdefs coming... -- Regards, Mike