Re: Re: [VOTE] Default character encoding

Hi Stas, On Mon, Jan 27, 2014 at 7:42 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > On Mon, Jan 27, 2014 at 7:35 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote: > >> > For the record, I committed this patch to 5.4 and up. >> >> You seem to be talking about different patch. The patch I am talking >> about is https://github.com/php/php-src/pull/568, it was >> not committed >> anywhere (and definitely not in 5.4 as it is targeted to be in 5.6) and >> Travis shows segfaults on it (see >> https://travis-ci.org/php/php-src/builds/17247814) which >> are not it >> regular master Travis tests. >> >> > The segfaults of zend engine are irrelevant for this proposal. >> >> I disagree, segfaults caused by the patch are very relevant. > > > I fetched and merged changes from original php-src into my fork. > I shouldn't have done that :( > > I'm guessing that's the reason why we see failed tests. > Finding out what's wrong now. Just a moment. > It takes time for rebuild and full tests. > I'm running several rebuild and full tests now. It will take a while. If there is problem, I'll fix them in this pull request. Anyway, sorry for the confusion. For the time being, we may mark zend_multibyte tests as XFAIL. I'll make time to fix them later. What do you think? Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net