Re: Re: [VOTE] Default character encoding

On Sun, Jan 26, 2014 at 11:31 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > On Mon, Jan 27, 2014 at 7:18 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > > > On Mon, Jan 27, 2014 at 5:15 AM, Stas Malyshev <smalyshev@sugarcrm.com > >wrote: > > > >> > Typical configuration works, but it's better to be resolved soon bugs. > >> > I don't have much time now, so I hope someone has time to take care.... > >> > >> Well, we can not merge a patch that segfaults. So until this is fixed, > >> that patch is a no go. > > > > > > The patch is not causing segfaults. > > > > Zend engine is segfaulting for zend_multibyte tests. > > It's a separate issue. You'll see segfaults in 5.4 and up without > > my patch. > > > > I've merged zend_multibyte tests fixes already. That's the reason why you > > see failing tests on 5.4 and up. > > > > It's a different issue and if nobody is willing to fix. I'll fix > > zend_multibyte > > next month. > > > > > For the record, I committed this patch to 5.4 and up. > As you can see, the patch is simply re-enabled tests for 5.4 and up. > (Note: there is no mbstring.script_encoding INI for 5.4 and up. It's > removed.) > hi, it is a bit off-topic, but could you please send a patch for the documentation about the mbstring.script_encoding ini change? it seems that it isn't documented that we removed that ini http://docs.php.net/manual/en/migration54.ini.php that would also let us resolve these two issues: https://bugs.php.net/bug.php?id=61232&edit=1 https://bugs.php.net/bug.php?id=65520&edit=1 thanks! -- Ferenc Kovács @Tyr43l - http://tyrael.hu