Re: com php-src: Set default Digest Message to use SHA1 instead of MD5 in openssl tests as MD5 signature are now rejected by newer openssl Version.:
ext/openssl/tests/openssl.cnf
| From: | Remi Collet | Date: | Thu, 06 Mar 2014 10:45:03 +0000 |
| Subject: | Re: com php-src: Set default Digest Message to use SHA1 instead of MD5 in openssl tests as MD5 signature are now rejected by newer openssl Version.: ext/openssl/tests/openssl.cnf |
||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-72971@lists.php.net to get a copy of this message | ||
Le 06/03/2014 10:14, Remi Collet a écrit :
> Commit: 721b9a7c8dbe52cd3f0d2ac69b8eb9c78a0721c9
> Author: Remi Collet <remi@php.net> Thu, 6 Mar 2014 10:14:08 +0100
> Parents: c2a9f73c99065cd8a7d3c08583498053076e1265
> Branches: PHP-5.4 PHP-5.5 PHP-5.6 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=721b9a7c8dbe52cd3f0d2ac69b8eb9c78a0721c9
>
> Log:
> Set default Digest Message to use SHA1 instead of MD5 in openssl tests
> as MD5 signature are now rejected by newer openssl Version.
This is only a woraround for stable branch.
But it seems a bit strange to generate MD we cannot check... (with
default config)
Don't you think it will be better to change,
in php_openssl_parse_config to:
if (req->md_alg == NULL) {
- req->md_alg = req->digest = EVP_md5();
+ req->md_alg = req->digest = EVP_sha1();
}
In 5.6+ ?
In older branch ?
Remi.
> Noticed in RHEL-7 and Fedora 21 build.
>
> Changed paths:
> M ext/openssl/tests/openssl.cnf
>
>
> Diff:
> diff --git a/ext/openssl/tests/openssl.cnf b/ext/openssl/tests/openssl.cnf
> index 4ed40fd..6ba37cb 100644
> --- a/ext/openssl/tests/openssl.cnf
> +++ b/ext/openssl/tests/openssl.cnf
> @@ -3,6 +3,7 @@ default_bits = 1024
> default_keyfile = privkey.pem
> distinguished_name = req_distinguished_name
> attributes = req_attributes
> +default_md = sha1
> x509_extensions = v3_ca # The extensions to add to the self signed cert
> string_mask = MASK:4294967295
>
>