Re: Re: com php-src: Set default Digest Message to use SHA1 instead of MD5 in openssl tests as MD5 signature are now rejected by newer openssl
Version.: ext/openssl/tests/openssl.cnf
| From: | Joe Orton | Date: | Thu, 06 Mar 2014 11:06:40 +0000 |
| Subject: | Re: Re: com php-src: Set default Digest Message to use SHA1 instead of MD5 in openssl tests as MD5 signature are now rejected by newer openssl Version.: ext/openssl/tests/openssl.cnf |
||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-72974@lists.php.net to get a copy of this message | ||
On Thu, Mar 06, 2014 at 11:45:03AM +0100, Remi Collet wrote:
> Don't you think it will be better to change,
> in php_openssl_parse_config to:
>
> if (req->md_alg == NULL) {
> - req->md_alg = req->digest = EVP_md5();
> + req->md_alg = req->digest = EVP_sha1();
> }
>
> In 5.6+ ?
I had suggested sha1 to confirm it fixes the test, but it would be
better to go with EVP_sha256() as the default since SHA-1 is now
considered insecure as well.
Regards, Joe