Possible tweak for tm2unixtime.c
| From: | Tig | Date: | Tue, 11 Mar 2014 06:14:40 +0000 |
| Subject: | Possible tweak for tm2unixtime.c | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-73055@lists.php.net to get a copy of this message | ||
Hello. I'm not sure, but I believe the following
do {} while code is
pointless in /ext/date/lib/tm2unixtime.c (located here:
https://github.com/php/php-src/blob/af6c11c5f060870d052a2b765dc634d9e47d0f18/ext/date/lib/tm2unixtime.c)
The code in question (appears a lot):
do {} while (do_range_limit(0, 60, 60, &rt->s, &rt->i));
The method do_range_limit() will always return 0, so why not just
call it like so:
do_range_limit(0, 60, 60, &rt->s, &rt->i);
And remove the do {} while loop.
There may be a reason why that loop code is there, but I'm not seeing
why. More than happy to be wrong.
-Tig