Re: Possible tweak for tm2unixtime.c

On Tue, Mar 11, 2014 at 2:11 AM, Tjerk Meesters <tjerk.meesters@gmail.com>wrote: > On Tue, Mar 11, 2014 at 2:14 PM, Tig <tigger.on@gmail.com> wrote: > > > Hello. I'm not sure, but I believe the following do {} > > while code is > > pointless in /ext/date/lib/tm2unixtime.c (located here: > > > > > õªoô<_¼Œ > ›ÒG‘¡https://github.com/php/php-src/blob/af6c11c5f060870d052a2b765dc634d9e47d0f18/ext/date/lib/tm2unixtime.c > > ) > > > > The code in question (appears a lot): > > > > do {} while (do_range_limit(0, 60, 60, &rt->s, &rt->i)); > > > > The method do_range_limit() will always return 0, so why > > not just > > call it like so: > > > > do_range_limit(0, 60, 60, &rt->s, &rt->i); > > > > And remove the do {} while loop. > > > > I can only tell you that removing them will cause 14 test cases to fail. > Unfortunately I can't tell you why that happens. > > > > > > There may be a reason why that loop code is there, but I'm not seeing > > why. More than happy to be wrong. > > > > -Tig > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > -- > -- > Tjerk > Do you recall which tests are those affected? --Kris