Re: Merge PR 621
| From: | Tjerk Meesters | Date: | Thu, 20 Mar 2014 23:23:11 +0000 |
| Subject: | Re: Merge PR 621 | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-73349@lists.php.net to get a copy of this message | ||
Hi Stas,
On Fri, Mar 21, 2014 at 6:02 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
> Hi!
>
> > The important part is that isset() triggers read_dimension and
> > eventually offsetGet() for isset(), and we seem to agree on that.
>
> Yes, agreed. Unfortunately, I'll be busy till the next week so couldn't
> propose a fix, but if nobody beats me to it I'll look at it next week.
>
It seems that PR 614 covers exactly that; it uses the check_empty flag
within spl_array_has_dimension_ex() to make sure offsetGet() is called when
needed.
https://github.com/php/php-src/pull/614
Was there something I missed there? I'm happy to work on this :)
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
--
--
Tjerk