Re: Merge PR 621
| From: | Tjerk Meesters | Date: | Tue, 25 Mar 2014 10:38:45 +0000 |
| Subject: | Re: Merge PR 621 | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-73421@lists.php.net to get a copy of this message | ||
Hi,
On Tue, Mar 25, 2014 at 11:54 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
> Hi!
>
> > It's my understanding that you should (have to) only call "get" if you
> > know that the offset exists.
>
> Yes, you are right. I'd still add some example that changes the keys to
> the tests to ensure all cases are covered properly. But looks like it
> works OK in all cases I could think of.
>
I've updated the test case with such an example.
PHP-5.6 and master have been updated.
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
--
--
Tjerk