Re: Pull Request #595

On Sat, Mar 22, 2014 at 11:13 AM, Chad Scribner <cwscribner@gmail.com>wrote: > Awesome, thank you very much! > > I'll have to do some more code spelunking to figure out the macros > mentioned in the PR comments as I'm still new to the code base. If/when I > put the comments into action, should I update my PR or create a new one? > On Mar 22, 2014 11:04 AM, "Sherif Ramadan" <theanomaly.is@gmail.com> > wrote: > >> >> >> >> On Fri, Mar 21, 2014 at 10:29 PM, Chad Scribner <cwscribner@gmail.com>wrote: >> >>> Hello All, >>> >>> I'm here to request that my pull request #595 get merged. It's a fix for >>> bug #52384 regarding PDO::debugDumpParams(). I've put the code and a >>> phpt >>> into the PR. You'll notice in the PR that the Travis CI build failed but >>> after investigating, my test did not fail. It looks as though it was due >>> to other code. This is my first time making a contribution so feel free >>> to >>> let me know if there's anything else I need to add. Thanks! >>> >>> ~Chad >>> >> >> >> Hey Chad, >> >> I took a look at your PR some time ago, I believe. Sorry, I did not have >> the time to merge it last time being so busy with work, but it looks good. >> I saw a few useful comments on the PR on github by nikic and datibbaw. >> Maybe take those under consideration. I'll be happy to merge it, though, if >> no one else does by tomorrow night. >> > You can just update the PR or I can do it for you. It's a simple change.