Re: Pull Request #595

Absolutely. Sorry for the delay! I've been in the process of rewiring a portion of my house so my dev time has been limited. On Apr 6, 2014 7:58 PM, "Stas Malyshev" <smalyshev@sugarcrm.com> wrote: > Hi! > > > I'm here to request that my pull request #595 get merged. It's a fix for > > bug #52384 regarding PDO::debugDumpParams(). I've put the code and a > phpt > > into the PR. You'll notice in the PR that the Travis CI build failed but > > after investigating, my test did not fail. It looks as though it was due > > to other code. This is my first time making a contribution so feel free > to > > let me know if there's anything else I need to add. Thanks! > > There are some notes on the pull, mainly about code style but also on > substance. Could you look at them and try to address them? > > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 >