Re: session_reset() and session_abort() to send errors
| From: | Yasuo Ohgaki | Date: | Fri, 04 Apr 2014 09:48:43 +0000 |
| Subject: | Re: session_reset() and session_abort() to send errors | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-73594@lists.php.net to get a copy of this message | ||
Hi Andrey,
On Tue, Apr 1, 2014 at 6:20 PM, Andrey Andreev <narf@devilix.net> wrote:
> >> Well, I just re-checked it and does indeed just call
> >> php_session_initialize(), so what's the point? Shorthand for
> >> session_abort() && session_start() ?
> >
> >
> > Yes, it's an API for it.
> > It's more efficient than user land functions as it requires needless
> > close and open (and initialization required to open).
>
> I'm confused now, does it call open() or does it not?
> If it doesn't - it's unsafe.
>
It's safe as long as handler locks data during read/write.
Example is memcached save handler with unlocked session.
If it does - it's unclear, redundant and optimizes by silently
> discarding already open resources (without properly closing them).
>
> Either way, I like efficiency but I also see it as flawed.
>
Save handler may lock/unlock session data. There is no standardized
way for it.
Since there would not be lock option for session manager, I don't mind
removing it. There is not much point to have it without lock option for
session manager. I would like to have session_gc() than session_reset().
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net