Re: com php-src: Update UPGRADING according to bug fix: UPGRADING

On Mon, May 19, 2014 at 9:22 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > On Sat, May 17, 2014 at 3:09 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote: > >> could anybody verify this? > > > It was hardcoded default. Therefore, I changed the default according to > RFC. > I don't mind make it use internal encoding at all. > In fact, I prefer to use internal encoding rather than using hardcoded > default. > I should mention that there is one issue. Encodings that are supported by Oniguruma and libmbfl differs. libmbfl supports more encodings than Oniguruma. Users may experience errors/wrong behaviors when they use unsupported encoding. The same applies to iconv also. Therefore, it may be safer using hardcoded default and encourage users to use proper encoding with mb regex. I prefer setting mb regex encoding to internal encoding, though. Currently, mb regex does not have automatic encoding conversion. It may be better to convert encoding to hardcoded default or user setting. There is no perfect & feasible solution now. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net