Re: Re: com php-src: Bug 49898 __getCookies() method implementation: ext/soap/soap.c ext/soap/tests/bug49898.phpt

On 19 June 2014 10:37, Peter Cowburn <petercowburn@gmail.com> wrote: > On 19 June 2014 18:18, Ferenc Kovacs <tyra3l@gmail.com> wrote: >> Yeah, but this SoapClient::__getCookies() was added to both 5.4 and >> 5.5(5.4.30 and 5.5.14 respectively, none of those are released yet), so we >> can't say "PHP 5 >= 5.5.14" and saying "PHP 5 >= 5.4.30" >> would imply that we >> have it in 5.5.0 which isn't the case. > > > The example was for only one branch. My suggestion, for this particular > case, would be a version string like: > > PHP 5 >= 5.4.30 and < 5.5.0, PHP 5 >= 5.5.14 > >> >> >>> >>> Then we could add on the 5.6 version info too, after a comma (we do this >>> *very* regularly, for example when an ext is available in PHP and PECL).. In >>> the end, whichever way we do choose, it's still going to be messy! >>> >> >> >> yeah, I can't really come up with anything simple and unambiguous. > > > This is why we don’t add new features in bug fix releases (or, shouldn’t). > ;) The best I've got is PHP 5.4 >= 5.4.30, PHP 5 >= 5.5.14, but I'm not thrilled with that either. We'll probably have to add a note somewhere in the main content. Adam