Re: [DRAFT][RFC] Big Integer Support

On 20 Jun 2014, at 17:47, Tjerk Meesters <tjerk.meesters@gmail.com> wrote: > Regarding the pow() operator, if both operands are IS_LONG it does multiplications if the > exponent is positive; I don't see that logic repeated in the IS_BIGINT cases. Was that causing > issues? That’s because I modified the existing code which manually computed pow() for two ints and overflowed to float, by simply making it overflow to bigint instead. The IS_BIGINT cases use the zend_bigint pow functions instead. > > Also, I noticed a couple of merge commits on your branch that you may wish to iron out :) > I ought to, but that would mean rewriting history, and I’d rather not do that in case it breaks some fork or what have you. I actually have an abandoned fork of my own bigint branch which does bitwise ops differently, though I don’t care for it. Maybe, if this eventually is merged into phpng, I could rebase them out then. -- Andrea Faulds http://ajf.me/