Re: ext/standard/tests/http/bug60570.phpt failure

On Wed, Aug 20, 2014 at 7:24 AM, Dmitry Stogov <dmitry@zend.com> wrote: > Anyone objects about it or thinks it needs RFC? > > Thanks. Dmitry. > > > On Wed, Aug 20, 2014 at 6:48 AM, Laruence <laruence@php.net> wrote: > >> Hey: >> >> >> On Tue, Aug 19, 2014 at 10:10 PM, Dmitry Stogov <dmitry@zend.com> wrote: >> > Hi, >> > >> > Yesterday we discussed with Nikta the failure of >> > ext/standard/tests/http/bug60570.phpt. It was in context of AST patch, >> but >> > the failure is not related to AST at all. It's just a bad test that makes >> > wrong assumption. >> > >> > Resource leaks can't be caught using get_memory_usage(). >> > >> > To have a robust way to detect resource leaks I propose a new function - >> > get_resources() that returns an array of all registered resources or an >> > array of registered resources of particular type. See patch: >> > >> > https://gist.github.com/dstogov/f96c04f5979e726909ab >> > >> > I'm not sure if such small change needs RFC. >> > >> > Thoughts? >> I think it's okey to have a such function. >> >> we have get_defined_functions/constants/vars >> >> thanks I would have then called it get_defined_resources() , for consistency. Julien.P