Re: Re: 64 bit string offsets
| From: | Anatol Belski | Date: | Mon, 01 Sep 2014 17:07:39 +0000 |
| Subject: | Re: Re: 64 bit string offsets | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-77012@lists.php.net to get a copy of this message | ||
Hi Dmitry,
On Mon, September 1, 2014 16:17, Dmitry Stogov wrote:
> Hi Anatol,
>
>
> what do you mean? heap allocated structure? I think, it's not a good
> option :(
>
> I didn't have time to think about this yet.
>
I thought about creating an extended zend_string struct with an appended
offset member. Pointer to that structure could be injected into
_zend_value and were compatible with the normal zend_string and would be
used only for the offset case. But then, we could get rid of u2.str_offset
and change the meaning of the IS_STR_OFFSET related macros.
That struct could be initialized the same way as any other in an opcode.
However I have yet to figure out where in the compiler this has to happen
(somewhere near the zend_compile_assign() i suppose).
Regards
Anatol