Re: Add a new flag for json_encode
| From: | Ferenc Kovacs | Date: | Sat, 29 Nov 2014 10:45:36 +0000 |
| Subject: | Re: Add a new flag for json_encode | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79308@lists.php.net to get a copy of this message | ||
On Sat, Nov 29, 2014 at 5:39 AM, Levi Morrison <levim@php.net> wrote:
> On Fri, Nov 28, 2014 at 1:21 PM, Juan Basso <jrbasso@gmail.com> wrote:
> > Over 20 days since the last comment and seems there is a consensus about
> > accept it to the next 5.6 patch version, right? Can it be merged?
>
> After reading over the thread, there doesn't seem to be a consensus; I
> am not sure how you arrived at this conclusion. If I have misread the
> thread and there is indeed a consensus then I apologize for
> contributing noise.
>
Levi: only Jakub was arguing against it, and even he was ok with the new
behavior, he just argued to make it default, and that if we really need the
option to disable it.
Kris: the general consensus seems to be that not every minor pull request
needs an RFC but ofc. usually it helps to move forward and get consensus,
so it won't hurt if we have one for this.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu