Re: Zend language parser improvements

On Wed, Dec 3, 2014 at 8:06 PM, Levi Morrison <levim@php.net> wrote: > The parser changes need to be careful reviewed; I don't have time at > the moment to verify it but I think you unintentionally allowed some > syntax's that shouldn't be valid because of the addition to > inner_statement. > Shouldn't. I broke down class_declaration_statement into 3 pieces: class_declaration_statement, interface_declaration_statement and trait_declaration_statement. At the end, all I've done is adding the other 2 new rules back to where it was consumed. > > Maybe I just looked too quickly. In any case, parser changes should > always get several people reviewing them. > Agreed. =) -- Guilherme Blanco MSN: guilhermeblanco@hotmail.com GTalk: guilhermeblanco Toronto - ON/Canada