Re: [VOTE][RFC] ZPP Failure on Overflow

Hey: On Wed, Dec 3, 2014 at 5:44 AM, Andrea Faulds <ajf@ajf.me> wrote: > Good evening once again, > > I’m putting the ZPP Failure on Overflow RFC to a vote. This RFC is an important prerequisite > to the Big Integer Support RFC, as it ensures safety in implicit integer parameter conversions. > > The RFC requires a 2/3 majority, and voting starts today (2014-12-02) and ends in 10 days’ > time next Friday (2014-12-12). > > Please read the RFC carefully. If you have any doubts or queries about the RFC, please don’t > hesitate to ask me. > > The RFC and voting widget can be found here: > https://wiki.php.net/rfc/zpp_fail_on_overflow > > Thanks! I am not sure if I misunderstand your proposal.. I thought you proposal is only fail if double value is out of long range but from your patch, ext/date/tests/date_sunset_variation9.phpt is fails with a double value 12.*** (which is obviously not out of long range). thanks > -- > Andrea Faulds > http://ajf.me/ > > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/