Re: Re: [VOTE][RFC] ZPP Failure on Overflow
| From: | Andrea Faulds | Date: | Tue, 09 Dec 2014 13:04:00 +0000 |
| Subject: | Re: Re: [VOTE][RFC] ZPP Failure on Overflow | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79494@lists.php.net to get a copy of this message | ||
Hi!
> On 9 Dec 2014, at 03:39, Xinchen Hui <laruence@php.net> wrote:
>
> Hey:
> that will confuse people, why 12.2 is okey (it's also a double value).
>
> anyway, I am not a native english speaker, not sure what is the most
> proper warning message.
>
> but I suggest change it to "expects parameter 1 to be long,
> double(which is beyond long range) given in %s on line %d"
>
> what do you think?
I realise the behaviour is somewhat confusing, but we also do this for other parameter parsing
failures and I don't have the time to go through and change all the tests again, unfortunately.
I'd also need to change how error messages are produced for fast parameter parsing.
Thanks.
--
Andrea Faulds
http://ajf.me/