Re: Re: [VOTE][RFC] ZPP Failure on Overflow

Hey: On Mon, Dec 8, 2014 at 7:15 PM, Andrea Faulds <ajf@ajf.me> wrote: > >> On 8 Dec 2014, at 08:22, Xinchen Hui <laruence@php.net> wrote: > >> the current warning message is :" expects parameter 1 to be long, >> double given in %s on line %d" >> >> but maybe it should be something like: "expects parameter 1 to be >> long, double(which is beyond long range) given in %s on line %d"? >> >> since it's not the fault of double self, right? > > Hi Xinchen, > > I had thought of doing that, although for all other failures we also don't give special > error messages. I don't have the time to go through and update every single test again, though. > I initially did have an error message that showed the range that the float needs to have, but this > was a problem because it means the error message might vary by platform (pain to test) that will confuse people, why 12.2 is okey (it's also a double value). anyway, I am not a native english speaker, not sure what is the most proper warning message. but I suggest change it to "expects parameter 1 to be long, double(which is beyond long range) given in %s on line %d" what do you think? thanks > > -- > Andrea Faulds > http://ajf.me/ -- Xinchen Hui @Laruence http://www.laruence.com/