Re: Re: [VOTE][RFC] ZPP Failure on Overflow
| From: | Andrea Faulds | Date: | Tue, 09 Dec 2014 14:10:22 +0000 |
| Subject: | Re: Re: [VOTE][RFC] ZPP Failure on Overflow | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79499@lists.php.net to get a copy of this message | ||
> On 9 Dec 2014, at 13:23, Rowan Collins <rowan.collins@gmail.com> wrote:
>
> Xinchen Hui wrote on 09/12/2014 03:39:
>> but I suggest change it to "expects parameter 1 to be long,
>> double(which is beyond long range) given in %s on line %d"
>
> Note that in master, the messages have been changed to (correctly) not mention the C types,
> only the PHP ones, so it would be more like "expects parameter 1 to be integer, float (which is
> beyond integer range) given".
They... have? When did this happen? It's something I was very much in favour of and wanted to
do myself, but I was unaware this had recently changed. Does that mean I'll have to redo the
patch for this RFC? :(
--
Andrea Faulds
http://ajf.me/