Re: [VOTE][RFC] ZPP Failure on Overflow
| From: | Andrea Faulds | Date: | Thu, 04 Dec 2014 05:54:43 +0000 |
| Subject: | Re: [VOTE][RFC] ZPP Failure on Overflow | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79410@lists.php.net to get a copy of this message | ||
> On 4 Dec 2014, at 05:51, Xinchen Hui <laruence@php.net> wrote:
>
>>
> I am not sure if I misunderstand your proposal..
>
> I thought you proposal is only fail if double value is out of long range
>
> but from your patch, ext/date/tests/date_sunset_variation9.phpt is
> fails with a double value 12.*** (which is obviously not out of long
> range).
That one caught me out too! Look more carefully, I missed it the first time.
12.3456789000e10 has a sneaky “e10” at the end, so it’s more like 123456789000 ;)
--
Andrea Faulds
http://ajf.me/